[lld] [LLD][COFF] Generate X64 thunks for ARM64EC entry points and patchable functions. (PR #105499)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 13:48:19 PDT 2024


mstorsjo wrote:

The commit message (PR description) seems to have a couple of sentences that feel weird/typoed:

> The condition here is that the function is that it has to be ARM64EC functions

The repeated "is that" feels like the sentence was rewritten without updating all of it.

> symbol and it fails to do so

"and _if_ it fails to do so"

> to provide and information about their redirection.

Superfluous "and"?

And the whole last paragraph, which talks about what you're planning on submitting next, should be left out of the description, so it doesn't end up in the commit message. (Sure, when merging, it's still possible to just edit it out at that point, but it's maybe best to clean up the PR description ahead of time anyway.)

https://github.com/llvm/llvm-project/pull/105499


More information about the llvm-commits mailing list