[llvm] [AArch64] Optimize when storing symmetry constants (PR #93717)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 11:54:19 PDT 2024


vitalybuka wrote:

> ask you a question? is what used in build-test different from test-suite?

It runs with Asan, isn't this report is not enough?

```
FAILED: include/llvm/TargetParser/AArch64TargetParserDef.inc /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm_build_asan/include/llvm/TargetParser/AArch64TargetParserDef.inc 
cd /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm_build_asan && /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm_build_asan/bin/llvm-min-tblgen -gen-arm-target-def -I /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Target/AArch64/ -I /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/include/llvm/TargetParser -I/home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm_build_asan/include -I/home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/include /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Target/AArch64/AArch64.td --write-if-changed -o include/llvm/TargetParser/AArch64TargetParserDef.inc -d include/llvm/TargetParser/AArch64TargetParserDef.inc.d
=================================================================
==263935==ERROR: AddressSanitizer: stack-use-after-scope on address 0xe97677d97b28 at pc 0xbf998ddcbfe8 bp 0xffffe4cb9b30 sp 0xffffe4cb9b28
READ of size 8 at 0xe97677d97b28 thread T0
    #0 0xbf998ddcbfe4 in operator()<unsigned long, unsigned long> /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/libcxx_build_asan/include/c++/v1/__algorithm/comp.h:41:12
    #1 0xbf998ddcbfe4 in min<unsigned long, std::__1::__less<void, void> > /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/libcxx_build_asan/include/c++/v1/__algorithm/min.h:30:10
    #2 0xbf998ddcbfe4 in min<unsigned long> /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/libcxx_build_asan/include/c++/v1/__algorithm/min.h:36:10
    #3 0xbf998ddcbfe4 in llvm::StringRef::find_first_not_of(llvm::StringRef, unsigned long) const /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/StringRef.cpp:265:22
    #4 0xbf998ddc33d0 in ltrim /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/include/llvm/ADT/StringRef.h:783:42
    #5 0xbf998ddc33d0 in trim /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/include/llvm/ADT/StringRef.h:807:14
    #6 0xbf998ddc33d0 in llvm::formatv_object_base::parseReplacementItem(llvm::StringRef) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/FormatVariadic.cpp:60:30
    #7 0xbf998ddc3be4 in llvm::formatv_object_base::splitLiteralAndReplacement(llvm::StringRef) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/FormatVariadic.cpp:135:15
    #8 0xbf998ddc42e0 in llvm::formatv_object_base::parseFormatString(llvm::StringRef) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/FormatVariadic.cpp:151:24
    #9 0xbf998ddf5870 in llvm::formatv_object_base::format(llvm::raw_ostream&) const /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/include/llvm/Support/FormatVariadic.h:86:20
    #10 0xbf998ddf5770 in llvm::raw_ostream::operator<<(llvm::formatv_object_base const&) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/raw_ostream.cpp:351:7
    #11 0xbf998dd2ba30 in EmitARMTargetDef(llvm::RecordKeeper&, llvm::raw_ostream&) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/utils/TableGen/ARMTargetDefEmitter.cpp:270:8
    #12 0xbf998de2bc48 in llvm::TableGenMain(char const*, std::__1::function<bool (llvm::raw_ostream&, llvm::RecordKeeper&)>) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/TableGen/Main.cpp:136:5
    #13 0xbf998dd251c8 in main /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/utils/TableGen/TableGen.cpp:84:10
    #14 0xed7679c284c0  (/lib/aarch64-linux-gnu/libc.so.6+0x284c0) (BuildId: 3119d7bcf68a34e21742cd08095272de601d373f)
    #15 0xed7679c28594 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x28594) (BuildId: 3119d7bcf68a34e21742cd08095272de601d373f)
    #16 0xbf998dc3ea2c in _start (/home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm_build_asan/bin/llvm-min-tblgen+0x15ea2c)
Address 0xe97677d97b28 is located in stack of thread T0 at offset 296 in frame
    #0 0xbf998ddc32e8 in llvm::formatv_object_base::parseReplacementItem(llvm::StringRef) /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/FormatVariadic.cpp:59
  This frame has 10 object(s):
    [32, 48) 'ref.tmp.i179'
    [64, 80) 'ref.tmp.i160'
    [96, 112) 'ref.tmp.i129'
    [128, 136) 'ULLVal.i.i'
    [160, 176) 'ref.tmp.i101'
    [192, 200) 'ULLVal.i'
    [224, 240) 'ref.tmp.i82'
    [256, 272) 'ref.tmp.i'
    [288, 304) 'Spec' <== Memory access at offset 296 is inside this variable
    [320, 336) 'RepString' (line 60)
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-use-after-scope /home/b/sanitizer-aarch64-linux-bootstrap-asan/build/llvm-project/llvm/lib/Support/StringRef.cpp:265:22 in llvm::StringRef::find_first_not_of(llvm::StringRef, unsigned long) const
Shadow bytes around the buggy address:
  0xe97677d97880: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97900: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97980: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97a00: f1 f1 f1 f1 f8 f8 f2 f2 f8 f8 f2 f2 f8 f8 f2 f2
  0xe97677d97a80: f8 f2 f2 f2 f8 f8 f2 f2 f8 f2 f2 f2 f8 f8 f2 f2
=>0xe97677d97b00: 00 00 f2 f2 f8[f8]f2 f2 00 00 f3 f3 00 00 00 00
  0xe97677d97b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0xe97677d97c00: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97c80: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97d00: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
  0xe97677d97d80: f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5 f5
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==263935==ABORTING
```



https://github.com/llvm/llvm-project/pull/93717


More information about the llvm-commits mailing list