[llvm] [TableGen] Rework `EmitIntrinsicToBuiltinMap` (PR #104681)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 11:10:07 PDT 2024


jurahul wrote:

> > > Thanks @arsenm. I realized though that change in the `BuiltinEntry` struct is actually a space regression. We have one
> > > ,,,
> > > @Artem-B ^^
> 
> I doubt that the space used for builtins info makes any practical difference. If it does not affect or improves performance, I'm fine with it.

In the sense, fine with using the old form, or fine with the extra bloat for clarity (i.e., switch to using StringRef)? I agree that this space is not going to make a difference, but migrating to StringRef does not help perf as well, but does make the code easier to understand (in case someone decides to read this generated code). Please let me know your preference.

https://github.com/llvm/llvm-project/pull/104681


More information about the llvm-commits mailing list