[lld] [lld][test] Removed curly braces from test to work with lit internal shell (PR #105137)

Connie Zhu via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 10:19:56 PDT 2024


https://github.com/connieyzhu created https://github.com/llvm/llvm-project/pull/105137

This patch rewrites a test to no longer use curly braces, as curly brace syntax is not currently supported by llvm-lit's internal shell implementation.

Fixes https://github.com/llvm/llvm-project/issues/102382.

>From fc26331e2ff41442da12c06e62ec90e423e52327 Mon Sep 17 00:00:00 2001
From: Connie Zhu <connieyzhu at google.com>
Date: Tue, 20 Aug 2024 17:12:19 +0000
Subject: [PATCH] [lld][test] Removed curly braces from test to work with lit
 internal shell

This patches rewrites a test to no longer use curly braces, as curly
brace syntax is not currently supported by llvm-lit's internal shell
implementation.
---
 lld/test/ELF/error-handling-script-linux.test | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lld/test/ELF/error-handling-script-linux.test b/lld/test/ELF/error-handling-script-linux.test
index 54e1b29ab236a6..c5c7b31ec04043 100755
--- a/lld/test/ELF/error-handling-script-linux.test
+++ b/lld/test/ELF/error-handling-script-linux.test
@@ -18,7 +18,9 @@
 # RUN: not ld.lld -o /dev/null --no-demangle --error-handling-script=%s %t2.o 2>&1 |\
 # RUN:   FileCheck --check-prefix=CHECK-SYM-CXX-NO-DEMANGLE %s
 
-# RUN: { echo 'a_: ret'; echo 'bar: movl a(%rip), %eax' ; } | llvm-mc -filetype=obj -triple=x86_64 - -o %t3.o
+# RUN: echo 'a_: ret' > %t
+# RUN: echo 'bar: movl a(%rip), %eax' >> %t
+# RUN: cat %t | llvm-mc -filetype=obj -triple=x86_64 - -o %t3.o
 # RUN: not ld.lld -o /dev/null --error-handling-script=%s %t3.o 2>&1 |\
 # RUN:   FileCheck --check-prefix=CHECK-SYM-C-CORRECTION -DOBJ=%t3.o %s
 



More information about the llvm-commits mailing list