[llvm] [instCombine][bugfix] Fix crash caused by using of cast in instCombineSVECmpNE (PR #102472)

via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 20:21:33 PDT 2024


wuxie2022 wrote:

> Yes, having a test case that only exposes a failure when asserts are enable is legitimate and expected because all active LLVM development should be done when asserts are enabled, otherwise you're minimising your test coverage.
> 
> Whilst the other test case crashes with a release compiler today, a crash is inherently unexplained and so the same test might not crash in the future. For example, you already mention the need for `-O2`, which enables many code paths that are unrelated to the code you've fixed. The simpler test makes it clearer how the code is linked to the affected assert.

Thank you for your explanation. I will modify the case.

https://github.com/llvm/llvm-project/pull/102472


More information about the llvm-commits mailing list