[lld] [lld][WebAssembly] Fix relocation of Wasm table index with GOT access (PR #104043)

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 12:49:35 PDT 2024


================
@@ -0,0 +1,27 @@
+# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
----------------
sbc100 wrote:

I wonder if we can give this test a better name?   Perhaps `bad-pic-relocations.s`?  

Could we split this test and the corresponding change into a separate PR?

Also, presumably the same error should occur for `R_WASM_MEMORY_ADDR_REL_` relocations against undefined symbols? 

BTW, how were you able to reproduce this error in the wild?   e.g. did it require writing assembly?

https://github.com/llvm/llvm-project/pull/104043


More information about the llvm-commits mailing list