[compiler-rt] a567d45 - Require !windows instead of XFAIL'ing ubsan/TestCases/Integer/bit-int.c

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 06:34:36 PDT 2024


Author: Hans Wennborg
Date: 2024-08-19T15:34:17+02:00
New Revision: a567d4598755219e535eb04d21b43c3624526714

URL: https://github.com/llvm/llvm-project/commit/a567d4598755219e535eb04d21b43c3624526714
DIFF: https://github.com/llvm/llvm-project/commit/a567d4598755219e535eb04d21b43c3624526714.diff

LOG: Require !windows instead of XFAIL'ing ubsan/TestCases/Integer/bit-int.c

The test would unexpectedly pass on Windows when there's 128-bit runtime
routines available. See comment on #104494

Added: 
    

Modified: 
    compiler-rt/test/ubsan/TestCases/Integer/bit-int.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/ubsan/TestCases/Integer/bit-int.c b/compiler-rt/test/ubsan/TestCases/Integer/bit-int.c
index 48f718285b06a1..d7e2c6dc60aa0b 100644
--- a/compiler-rt/test/ubsan/TestCases/Integer/bit-int.c
+++ b/compiler-rt/test/ubsan/TestCases/Integer/bit-int.c
@@ -1,9 +1,7 @@
 // REQUIRES: x86_64-target-arch
+// REQUIRES: !windows
 // RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=array-bounds,float-cast-overflow,implicit-integer-sign-change,implicit-signed-integer-truncation,implicit-unsigned-integer-truncation,integer-divide-by-zero,pointer-overflow,shift-base,shift-exponent,signed-integer-overflow,unsigned-integer-overflow,unsigned-shift-base,vla-bound %s -o %t1 && %run %t1 2>&1 | FileCheck %s
 
-// FIXME: make the test pass on windows.
-// XFAIL: target={{.*windows-msvc.*}}
-
 #include <stdint.h>
 #include <stdio.h>
 


        


More information about the llvm-commits mailing list