[llvm] AMDGPU: Update live intervals in convertToThreeAddress (PR #104610)

[Carl Ritson via llvm-commits]

================
@@ -3976,9 +3994,10 @@ MachineInstr *SIInstrInfo::convertToThreeAddress(MachineInstr &MI,
                   .addImm(Imm)
                   .setMIFlags(MI.getFlags());
         updateLiveVariables(LV, MI, *MIB);
+        SlotIndex NewIdx;
         if (LIS)
-          LIS->ReplaceMachineInstrInMaps(MI, *MIB);
-        killDef();
+          NewIdx = LIS->ReplaceMachineInstrInMaps(MI, *MIB);
+        killDef(NewIdx);
----------------
perlfu wrote:

It seems a bit odd to be that this operates on the new slot index, but I guess this is because all references to the old index in intervals have been replaced with the new one?


https://github.com/llvm/llvm-project/pull/104610