[llvm] [RelocationResolver][Xtensa] Implement R_XTENSA_32 (PR #96311)

YAMAMOTO Takashi via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 01:33:14 PDT 2024


================
@@ -310,6 +310,28 @@ static uint64_t resolveX86(uint64_t Type, uint64_t Offset, uint64_t S,
   }
 }
 
+static bool supportsXtensa(uint64_t Type) {
+  switch (Type) {
+  case ELF::R_XTENSA_NONE:
+  case ELF::R_XTENSA_32:
+    return true;
+  default:
+    return false;
+  }
+}
+
+static uint64_t resolveXtensa(uint64_t Type, uint64_t Offset, uint64_t S,
+                              uint64_t LocData, int64_t Addend) {
+  switch (Type) {
+  case ELF::R_XTENSA_NONE:
----------------
yamt wrote:

i feel it's better for this kind of tools to handle more cases as far as it's legal and easy.
anyway your comment isn't specific to this PR, right?


https://github.com/llvm/llvm-project/pull/96311


More information about the llvm-commits mailing list