[llvm] [docs] Add note about "Re-request review" (PR #104735)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 18 22:54:01 PDT 2024


https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/104735

>From 8352ed1370a02ea55b3c326ceee2afd2229d882c Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at google.com>
Date: Sun, 18 Aug 2024 21:02:08 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
 =?UTF-8?q?itial=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Created using spr 1.3.4
---
 llvm/docs/CodeReview.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/llvm/docs/CodeReview.rst b/llvm/docs/CodeReview.rst
index ca57cffc519de8..d5658273c5111e 100644
--- a/llvm/docs/CodeReview.rst
+++ b/llvm/docs/CodeReview.rst
@@ -125,6 +125,11 @@ commit message).
 If you suggest changes in a code review, but don't wish the suggestion to be
 interpreted this strongly, please state so explicitly.
 
+.. note::
+   After responding to reviewer comments,
+   press `Re-request review <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review#:~:text=After%20your%20pull%20request%20is%20reviewed>`_
+   to bring the Pull Request to the reviewer's attention.
+
 Aim to Make Efficient Use of Everyone's Time
 --------------------------------------------
 

>From aafe7c9b6f191a40828a21b42135a99b1cce2758 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at google.com>
Date: Sun, 18 Aug 2024 22:53:46 -0700
Subject: [PATCH 2/2] reviewers'

Created using spr 1.3.4
---
 llvm/docs/CodeReview.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/docs/CodeReview.rst b/llvm/docs/CodeReview.rst
index d5658273c5111e..0128e37465de32 100644
--- a/llvm/docs/CodeReview.rst
+++ b/llvm/docs/CodeReview.rst
@@ -128,7 +128,7 @@ interpreted this strongly, please state so explicitly.
 .. note::
    After responding to reviewer comments,
    press `Re-request review <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review#:~:text=After%20your%20pull%20request%20is%20reviewed>`_
-   to bring the Pull Request to the reviewer's attention.
+   to bring the Pull Request to the reviewers' attention.
 
 Aim to Make Efficient Use of Everyone's Time
 --------------------------------------------



More information about the llvm-commits mailing list