[llvm] [PowerPC] Use MathExtras helpers to simplify code. NFC (PR #104691)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 17 19:52:26 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-powerpc
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/104691.diff
1 Files Affected:
- (modified) llvm/lib/Target/PowerPC/PPCISelLowering.cpp (+3-6)
``````````diff
diff --git a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
index fff39a37265f20..459a96eca1ff20 100644
--- a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
+++ b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
@@ -9513,10 +9513,8 @@ SDValue PPCTargetLowering::LowerBUILD_VECTOR(SDValue Op,
} else {
// We may lose precision, so we have to use XXSPLTI32DX.
- uint32_t Hi =
- (uint32_t)((APSplatBits.getZExtValue() & 0xFFFFFFFF00000000LL) >> 32);
- uint32_t Lo =
- (uint32_t)(APSplatBits.getZExtValue() & 0xFFFFFFFF);
+ uint32_t Hi = Hi_32(APSplatBits.getZExtValue());
+ uint32_t Lo = Lo_32(APSplatBits.getZExtValue());
SDValue SplatNode = DAG.getUNDEF(MVT::v2i64);
if (!Hi || !Lo)
@@ -9660,8 +9658,7 @@ SDValue PPCTargetLowering::LowerBUILD_VECTOR(SDValue Op,
dl);
// If the sign extended value is in the range [-16,15], use VSPLTI[bhw].
- int32_t SextVal= (int32_t(SplatBits << (32-SplatBitSize)) >>
- (32-SplatBitSize));
+ int32_t SextVal = SignExtend32(SplatBits, SplatBitSize);
if (SextVal >= -16 && SextVal <= 15)
return getCanonicalConstSplat(SextVal, SplatSize, Op.getValueType(), DAG,
dl);
``````````
</details>
https://github.com/llvm/llvm-project/pull/104691
More information about the llvm-commits
mailing list