[llvm] [SDAG] Read-only intrinsics must have WillReturn attribute to be treated as loads (PR #99999)

Kevin McAfee via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 09:45:17 PDT 2024


================
@@ -5229,7 +5229,7 @@ void SelectionDAGBuilder::visitTargetIntrinsic(const CallInst &I,
   // definition.
   const Function *F = I.getCalledFunction();
   bool HasChain = !F->doesNotAccessMemory();
----------------
kalxr wrote:

This seems like a good idea. When I add that there are many test failures, and the few I looked into are resolved by adding WillReturn. If it's okay, I would prefer that be added and the relevant intrinsics fixed in a separate PR so that we can land this one sooner.

https://github.com/llvm/llvm-project/pull/99999


More information about the llvm-commits mailing list