[llvm] [nfc] Improve testability of PGOInstrumentationGen (PR #104490)

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 09:34:15 PDT 2024


================
@@ -53,15 +53,18 @@ class PGOInstrumentationGenCreateVar
   bool ProfileSampling;
 };
 
+enum class PGOInstrumentationType { Invalid = 0, FDO, CSFDO, CTXPROF };
----------------
snehasish wrote:

I think the enum members should have a prefix based on guideline here: https://llvm.org/docs/CodingStandards.html#the-low-level-issues

Also camel case (though FDO is an acronym so I'm not sure). 

https://github.com/llvm/llvm-project/pull/104490


More information about the llvm-commits mailing list