[llvm] [NFC] [DSE] Refactor DSE (PR #100956)

Jan Voung via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 08:06:40 PDT 2024


================
@@ -2132,182 +2177,182 @@ struct DSEState {
     }
     return MadeChange;
   }
-};
 
-static bool eliminateDeadStores(Function &F, AliasAnalysis &AA, MemorySSA &MSSA,
-                                DominatorTree &DT, PostDominatorTree &PDT,
-                                const TargetLibraryInfo &TLI,
-                                const LoopInfo &LI) {
-  bool MadeChange = false;
+  // Try to eliminate dead defs killed by `KillingLocWrapper` and return the
----------------
jvoung wrote:

nit:  "eliminate dead defs killed by `KillingLocWrapper`" I'm not sure killed by KillingLocWrapper is as clear. Which part of KillingLocWrapper are the defs killed by? It's not the MemoryLocation parts right?



https://github.com/llvm/llvm-project/pull/100956


More information about the llvm-commits mailing list