[compiler-rt] [builtins] Fix divtc3.c etc. compilation on Solaris/SPARC with gcc (PR #101662)
Rainer Orth via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 05:28:52 PDT 2024
rorth wrote:
Neither of those works for 32-bit Solaris/sparc with gcc 14: the declarations of `__compiler_rt_logbtf` and friends in `fp_lib.h` all depend on `CRT_HAS_TF_MODE` being defined. If it's not (as in the sparc case), we're again breaking what my original patch fixed.
The more I see this, the more I wonder if it's wise to make changes here that no in-tree target needs, arguing about a WIP z/OS port that may or may not need changes. Maybe it's better to keep things as is for now and revisit this when that port is submitted for real and can be reviewed/tested as is, rather than arguing about unknown downstream code. That would mean making whatever change is necessary to fix your issue locally for now.
https://github.com/llvm/llvm-project/pull/101662
More information about the llvm-commits
mailing list