[llvm] [NFC] Cleanup in ADT and Analysis headers. (PR #104484)

[Jay Foad via llvm-commits]

jayfoad wrote:

> > > For reference: [compile-time-tracker run](https://llvm-compile-time-tracker.com/compare.php?from=141536544f4ec1d1bf24256157f4ff1a3bc07dae&to=9f78f2041a62ec3e5c2614ab5df66e8eb83ac9a2&stat=instructions:u) with the change.
> > 
> > 
> > Thanks, but that is measuring the speed of the generated LLVM binary. For a change like this, it would be more interesting to see whether the time taken to compile LLVM gets slower or (hopefully) faster. Or like I said before, you could use some other metric like the total number of preprocessed source lines.
> 
> The relevant number is instructions:u for "clang build" at the bottom. It's a minor 0.1% build time improvement. See also https://llvm-compile-time-tracker.com/compare_clang.php?from=141536544f4ec1d1bf24256157f4ff1a3bc07dae&to=9f78f2041a62ec3e5c2614ab5df66e8eb83ac9a2&stat=instructions%3Au&sortBy=interestingness for the per-file breakdown.

Thanks. That breakdown is pretty compelling, lots of green and hardly any red.

https://github.com/llvm/llvm-project/pull/104484