[llvm] [ORC] Add LoadRelocatableObject: universal binary support, clearer er… (PR #104406)

Thu Aug 15 19:33:01 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `polly-x86_64-linux-shared-plugin` running on `polly-x86_64-gce2` while building `llvm` at step 5 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/118/builds/1197

Here is the relevant piece of the build log for the reference:
```
Step 5 (build) failure: 'ninja' (failure)
...
[2108/4163] Creating export file for LTO
[2109/4163] Building CXX object tools/lto/CMakeFiles/LTO.dir/LTODisassembler.cpp.o
[2110/4163] Linking CXX shared library lib/libLLVMPasses.so.20.0git
[2111/4163] Linking CXX shared library lib/libLLVMX86CodeGen.so.20.0git
[2112/4163] Creating library symlink lib/libLLVMPasses.so
[2113/4163] Building CXX object tools/lto/CMakeFiles/LTO.dir/lto.cpp.o
[2114/4163] Creating library symlink lib/libLLVMX86CodeGen.so
[2115/4163] Building CXX object tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar.cpp.o
[2116/4163] Building CXX object tools/llvm-ar/CMakeFiles/llvm-ar.dir/llvm-ar-driver.cpp.o
[2117/4163] Linking CXX shared library lib/libLLVMOrcJIT.so.20.0git
FAILED: lib/libLLVMOrcJIT.so.20.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=lld -Wl,--color-diagnostics   -Wl,--gc-sections -shared -Wl,-soname,libLLVMOrcJIT.so.20.0git -o lib/libLLVMOrcJIT.so.20.0git lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/COFFVCRuntimeSupport.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/COFFPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/CompileOnDemandLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/CompileUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Core.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/DebugObjectManagerPlugin.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/DebugUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCDynamicLibrarySearchGenerator.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCDebugObjectRegistrar.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCEHFrameRegistrar.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericDylibManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericJITLinkMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericRTDyldMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCIndirectionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ExecutionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectFileInterface.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IndirectionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IRCompileLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IRTransformLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/JITTargetMachineBuilder.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LazyReexports.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Layer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LoadRelocatableObject.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LookupAndRecordAddrs.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LLJIT.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachO.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MapperJITLinkMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MemoryMapper.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ELFNixPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Mangling.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectLinkingLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectTransformLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/OrcABISupport.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/OrcV2CBindings.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/RTDyldObjectLinkingLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SectCreate.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SimpleRemoteEPC.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Speculation.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SpeculateAnalyses.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ExecutorProcessControl.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/TaskDispatch.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ThreadSafeModule.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/lib:"  -lrt  lib/libLLVMExecutionEngine.so.20.0git  lib/libLLVMJITLink.so.20.0git  lib/libLLVMOrcTargetProcess.so.20.0git  lib/libLLVMWindowsDriver.so.20.0git  lib/libLLVMPasses.so.20.0git  lib/libLLVMRuntimeDyld.so.20.0git  lib/libLLVMBitWriter.so.20.0git  lib/libLLVMTransformUtils.so.20.0git  lib/libLLVMTarget.so.20.0git  lib/libLLVMAnalysis.so.20.0git  lib/libLLVMObject.so.20.0git  lib/libLLVMBitReader.so.20.0git  lib/libLLVMCore.so.20.0git  lib/libLLVMMC.so.20.0git  lib/libLLVMOrcShared.so.20.0git  lib/libLLVMTargetParser.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/home/worker/buildbot-workers/polly-x86_64-gce2/rundir/llvm.obj/lib && :
ld.lld: error: undefined symbol: llvm::identify_magic(llvm::StringRef)
>>> referenced by LoadRelocatableObject.cpp
>>>               lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LoadRelocatableObject.cpp.o:(llvm::orc::loadRelocatableObject(llvm::StringRef, llvm::Triple const&))
>>> referenced by MachO.cpp
>>>               lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachO.cpp.o:(llvm::orc::loadMachORelocatableObject(llvm::StringRef, llvm::Triple const&))
collect2: error: ld returned 1 exit status
[2118/4163] Linking CXX shared library lib/libLLVMLTO.so.20.0git
[2119/4163] Linking CXX executable bin/llvm-ar
ninja: build stopped: subcommand failed.

```

https://github.com/llvm/llvm-project/pull/104406