[llvm] [Symbolizer, DebugInfo] Clean up LLVMSymbolizer API: const string& -> StringRef (PR #104541)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 19:27:45 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 648f4d0658ab00cf1e95330c8811aaea9481a274 aab2b2c075d7af5f60db6d0da66a0cc7129f0a35 --extensions h,cpp -- llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
index ada3c6b657..df2e806259 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
@@ -100,8 +100,7 @@ public:
Expected<std::vector<DILocal>>
symbolizeFrame(const ObjectFile &Obj, object::SectionedAddress ModuleOffset);
Expected<std::vector<DILocal>>
- symbolizeFrame(StringRef ModuleName,
- object::SectionedAddress ModuleOffset);
+ symbolizeFrame(StringRef ModuleName, object::SectionedAddress ModuleOffset);
Expected<std::vector<DILocal>>
symbolizeFrame(ArrayRef<uint8_t> BuildID,
object::SectionedAddress ModuleOffset);
@@ -132,8 +131,7 @@ public:
/// Only one attempt is made to load a module, and errors during loading are
/// only reported once. Subsequent calls to get module info for a module that
/// failed to load will return nullptr.
- Expected<SymbolizableModule *>
- getOrCreateModuleInfo(StringRef ModuleName);
+ Expected<SymbolizableModule *> getOrCreateModuleInfo(StringRef ModuleName);
private:
// Bundles together object file with code/data and object file with
``````````
</details>
https://github.com/llvm/llvm-project/pull/104541
More information about the llvm-commits
mailing list