[llvm] [Hexagon] Use range-based for loops (NFC) (PR #104538)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 18:56:59 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/104538
None
>From d8301e871dc5731689d09aa7d8c65dc9f68a3d33 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 14 Aug 2024 08:32:16 -0700
Subject: [PATCH] [Hexagon] Use range-based for loops (NFC)
---
llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp | 4 +---
llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp | 8 +++-----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp b/llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp
index a2230289ae69c7..59c882bf37afaa 100644
--- a/llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp
@@ -249,9 +249,7 @@ void HexagonCopyHoisting::moveCopyInstr(MachineBasicBlock *DestBB,
DestBB->splice(FirstTI, MI->getParent(), MI);
addMItoCopyList(MI);
- for (auto I = std::next(DestBB->succ_begin()), E = DestBB->succ_end(); I != E;
- ++I) {
- MachineBasicBlock *SuccBB = *I;
+ for (MachineBasicBlock *SuccBB : drop_begin(DestBB->successors())) {
auto &BBCopyInst = CopyMIList[SuccBB->getNumber()];
MachineInstr *SuccMI = BBCopyInst[Key];
SuccMI->eraseFromParent();
diff --git a/llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp b/llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp
index 651ccc2db9ba24..92574a16c4f931 100644
--- a/llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp
@@ -86,11 +86,9 @@ bool HexagonGenMemAbsolute::runOnMachineFunction(MachineFunction &Fn) {
getAnalysis<MachineDominatorTreeWrapperPass>().getDomTree();
// Loop over all of the basic blocks
- for (MachineFunction::iterator MBBb = Fn.begin(), MBBe = Fn.end();
- MBBb != MBBe; ++MBBb) {
- MachineBasicBlock *MBB = &*MBBb;
+ for (MachineBasicBlock &MBB : Fn) {
// Traverse the basic block
- for (MachineBasicBlock::iterator MII = MBB->begin(); MII != MBB->end();
+ for (MachineBasicBlock::iterator MII = MBB.begin(); MII != MBB.end();
++MII) {
MachineInstr *MI = &*MII;
int Opc = MI->getOpcode();
@@ -205,7 +203,7 @@ bool HexagonGenMemAbsolute::runOnMachineFunction(MachineFunction &Fn) {
LLVM_DEBUG(dbgs() << "Replaced with " << *MIB << "\n");
// Erase the instructions that got replaced.
- MII = MBB->erase(MI);
+ MII = MBB.erase(MI);
--MII;
NextMI->getParent()->erase(NextMI);
}
More information about the llvm-commits
mailing list