[llvm] [ORC] Add LoadRelocatableObject: universal binary support, clearer er… (PR #104406)

Thu Aug 15 17:26:35 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-sharedlibs` running on `linaro-flang-aarch64-sharedlibs` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/80/builds/2168

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
384.753 [5031/1/2312] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Profile.cpp.o
384.870 [5030/1/2313] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordInitializer.cpp.o
384.984 [5029/1/2314] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordPrinter.cpp.o
385.177 [5028/1/2315] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Trace.cpp.o
385.570 [5027/1/2316] Linking CXX shared library lib/libLLVMXRay.so.20.0git
385.752 [5026/1/2317] Creating library symlink lib/libLLVMXRay.so
386.027 [5025/1/2318] Building CXX object lib/WindowsDriver/CMakeFiles/LLVMWindowsDriver.dir/MSVCPaths.cpp.o
386.501 [5024/1/2319] Linking CXX shared library lib/libLLVMWindowsDriver.so.20.0git
386.577 [5023/1/2320] Creating library symlink lib/libLLVMWindowsDriver.so
388.262 [5022/1/2321] Linking CXX shared library lib/libLLVMOrcJIT.so.20.0git
FAILED: lib/libLLVMOrcJIT.so.20.0git 
: && /usr/local/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-sharedlibs/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMOrcJIT.so.20.0git -o lib/libLLVMOrcJIT.so.20.0git lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/COFFVCRuntimeSupport.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/COFFPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/CompileOnDemandLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/CompileUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Core.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/DebugObjectManagerPlugin.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/DebugUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCDynamicLibrarySearchGenerator.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCDebugObjectRegistrar.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCEHFrameRegistrar.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericDylibManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericJITLinkMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCGenericRTDyldMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/EPCIndirectionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ExecutionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectFileInterface.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IndirectionUtils.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IRCompileLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/IRTransformLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/JITTargetMachineBuilder.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LazyReexports.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Layer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LoadRelocatableObject.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LookupAndRecordAddrs.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LLJIT.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachO.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachOPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MapperJITLinkMemoryManager.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MemoryMapper.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ELFNixPlatform.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Mangling.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectLinkingLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ObjectTransformLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/OrcABISupport.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/OrcV2CBindings.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/RTDyldObjectLinkingLayer.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SectCreate.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SimpleRemoteEPC.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/Speculation.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/SpeculateAnalyses.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ExecutorProcessControl.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/TaskDispatch.cpp.o lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/ThreadSafeModule.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/tcwg-buildbot/worker/flang-aarch64-sharedlibs/build/lib:"  -lrt  lib/libLLVMExecutionEngine.so.20.0git  lib/libLLVMJITLink.so.20.0git  lib/libLLVMOrcTargetProcess.so.20.0git  lib/libLLVMWindowsDriver.so.20.0git  lib/libLLVMPasses.so.20.0git  lib/libLLVMRuntimeDyld.so.20.0git  lib/libLLVMBitWriter.so.20.0git  lib/libLLVMTransformUtils.so.20.0git  lib/libLLVMTarget.so.20.0git  lib/libLLVMAnalysis.so.20.0git  lib/libLLVMObject.so.20.0git  lib/libLLVMBitReader.so.20.0git  lib/libLLVMCore.so.20.0git  lib/libLLVMMC.so.20.0git  lib/libLLVMOrcShared.so.20.0git  lib/libLLVMTargetParser.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-sharedlibs/build/lib && :
/usr/bin/ld: lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/LoadRelocatableObject.cpp.o: in function `llvm::orc::loadRelocatableObject(llvm::StringRef, llvm::Triple const&)':
LoadRelocatableObject.cpp:(.text._ZN4llvm3orc21loadRelocatableObjectENS_9StringRefERKNS_6TripleE+0x68): undefined reference to `llvm::identify_magic(llvm::StringRef)'
/usr/bin/ld: lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/MachO.cpp.o: in function `llvm::orc::loadMachORelocatableObject(llvm::StringRef, llvm::Triple const&)':
MachO.cpp:(.text._ZN4llvm3orc26loadMachORelocatableObjectENS_9StringRefERKNS_6TripleE+0x74): undefined reference to `llvm::identify_magic(llvm::StringRef)'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

```

https://github.com/llvm/llvm-project/pull/104406