[llvm] 039a86d - [RISCV] Use significant bits helpers in narrowing of build vectors [nfc] (#104511)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 15 16:46:23 PDT 2024
Author: Philip Reames
Date: 2024-08-15T16:46:19-07:00
New Revision: 039a86d057b144c963f7a30f9b4b8d3da200576d
URL: https://github.com/llvm/llvm-project/commit/039a86d057b144c963f7a30f9b4b8d3da200576d
DIFF: https://github.com/llvm/llvm-project/commit/039a86d057b144c963f7a30f9b4b8d3da200576d.diff
LOG: [RISCV] Use significant bits helpers in narrowing of build vectors [nfc] (#104511)
Added:
Modified:
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index e16dd132ed71bb..515d7dbcd47bd9 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3813,16 +3813,14 @@ static SDValue lowerBuildVectorOfConstants(SDValue Op, SelectionDAG &DAG,
// TODO: We really should be costing the smaller vector. There are
// profitable cases this misses.
if (EltBitSize > 8 && VT.isInteger() &&
- (NumElts <= 4 || VT.getSizeInBits() > Subtarget.getRealMinVLen())) {
- unsigned SignBits = DAG.ComputeNumSignBits(Op);
- if (EltBitSize - SignBits < 8) {
- SDValue Source = DAG.getBuildVector(VT.changeVectorElementType(MVT::i8),
- DL, Op->ops());
- Source = convertToScalableVector(ContainerVT.changeVectorElementType(MVT::i8),
- Source, DAG, Subtarget);
- SDValue Res = DAG.getNode(RISCVISD::VSEXT_VL, DL, ContainerVT, Source, Mask, VL);
- return convertFromScalableVector(VT, Res, DAG, Subtarget);
- }
+ (NumElts <= 4 || VT.getSizeInBits() > Subtarget.getRealMinVLen()) &&
+ DAG.ComputeMaxSignificantBits(Op) <= 8) {
+ SDValue Source = DAG.getBuildVector(VT.changeVectorElementType(MVT::i8),
+ DL, Op->ops());
+ Source = convertToScalableVector(ContainerVT.changeVectorElementType(MVT::i8),
+ Source, DAG, Subtarget);
+ SDValue Res = DAG.getNode(RISCVISD::VSEXT_VL, DL, ContainerVT, Source, Mask, VL);
+ return convertFromScalableVector(VT, Res, DAG, Subtarget);
}
if (SDValue Res = lowerBuildVectorViaDominantValues(Op, DAG, Subtarget))
More information about the llvm-commits
mailing list