[llvm] [NFC] [DSE] Refactor DSE (PR #100956)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 15 12:56:32 PDT 2024


================
@@ -2132,182 +2177,182 @@ struct DSEState {
     }
     return MadeChange;
   }
-};
 
-static bool eliminateDeadStores(Function &F, AliasAnalysis &AA, MemorySSA &MSSA,
-                                DominatorTree &DT, PostDominatorTree &PDT,
-                                const TargetLibraryInfo &TLI,
-                                const LoopInfo &LI) {
-  bool MadeChange = false;
+  // Try to eliminate dead defs killed by `KillingLocWrapper` and return the
----------------
aeubanks wrote:

IIUC, `Shortened` really means "KillingI was deleted" (please correct me if I'm wrong). So maybe change the variable name to `DeletedKillingLoc` and the comment to

```
Try to eliminate dead defs killed by `KillingLocWrapper`. Return whether any changes were made, and whether `KillingLocWrapper` was deleted.
```

https://github.com/llvm/llvm-project/pull/100956


More information about the llvm-commits mailing list