[llvm] [CodeGen] Use a range-based for loop (NFC) (PR #104408)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 14 23:51:18 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/104408

None

>From 3dabe5c8bd830213204f91ebfa121292f4fd6102 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 13 Aug 2024 22:14:00 -0700
Subject: [PATCH] [CodeGen] Use a range-based for loop (NFC)

---
 llvm/lib/CodeGen/CodeGenPrepare.cpp | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp
index 1fb37fb8406ef4..ec5b7579c66c26 100644
--- a/llvm/lib/CodeGen/CodeGenPrepare.cpp
+++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp
@@ -7382,12 +7382,9 @@ bool CodeGenPrepare::tryToSinkFreeOperands(Instruction *I) {
     if (IsHugeFunc) {
       // Now we clone an instruction, its operands' defs may sink to this BB
       // now. So we put the operands defs' BBs into FreshBBs to do optimization.
-      for (unsigned I = 0; I < NI->getNumOperands(); ++I) {
-        auto *OpDef = dyn_cast<Instruction>(NI->getOperand(I));
-        if (!OpDef)
-          continue;
-        FreshBBs.insert(OpDef->getParent());
-      }
+      for (Value *Op : NI->operands())
+        if (auto *OpDef = dyn_cast<Instruction>(Op))
+          FreshBBs.insert(OpDef->getParent());
     }
 
     NewInstructions[UI] = NI;



More information about the llvm-commits mailing list