[compiler-rt] [scudo] Fix release to OS logic in secondary cache. (PR #103303)

Christopher Ferris via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 15:57:42 PDT 2024


================
@@ -585,32 +581,28 @@ class MapAllocatorCache {
     }
   }
 
-  void releaseIfOlderThan(CachedBlock &Entry, u64 Time) REQUIRES(Mutex) {
-    if (!Entry.isValid() || !Entry.Time)
-      return;
-    if (Entry.Time > Time) {
-      if (OldestTime == 0 || Entry.Time < OldestTime)
-        OldestTime = Entry.Time;
-      return;
-    }
+  inline void release(CachedBlock &Entry) {
----------------
cferris1000 wrote:

Would it be worth adding a DCHECK(Entry.time != 0) here?

https://github.com/llvm/llvm-project/pull/103303


More information about the llvm-commits mailing list