[llvm] 29314b4 - Revert "[CMake] Fix DynamicLibraryTests exports symbol when plugins are enabled (#102941)"

Steven Wu via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 13 13:59:25 PDT 2024


Author: Steven Wu
Date: 2024-08-13T13:59:12-07:00
New Revision: 29314b4b2720d6c14931832f3ca715981abed340

URL: https://github.com/llvm/llvm-project/commit/29314b4b2720d6c14931832f3ca715981abed340
DIFF: https://github.com/llvm/llvm-project/commit/29314b4b2720d6c14931832f3ca715981abed340.diff

LOG: Revert "[CMake] Fix DynamicLibraryTests exports symbol when plugins are enabled (#102941)"

This reverts commit a9604cd3212beb6cdb41a79f248723140ab9939d.

The export list in unit-tests will break sanitizer build since that
requires more symbols than listed in the export file.

Added: 
    

Modified: 
    llvm/unittests/Support/DynamicLibrary/CMakeLists.txt

Removed: 
    llvm/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports


################################################################################
diff  --git a/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt b/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
index ff0b2f07ee1363..d8dff1ef4a3f77 100644
--- a/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
+++ b/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
@@ -15,8 +15,6 @@ set_output_directory(DynamicLibraryLib
   LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}
   )
 
-set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/DynamicLibraryTests.exports)
-
 add_llvm_unittest(DynamicLibraryTests
   DynamicLibraryTest.cpp
 
@@ -24,8 +22,6 @@ add_llvm_unittest(DynamicLibraryTests
   )
 target_link_libraries(DynamicLibraryTests PRIVATE DynamicLibraryLib)
 
-unset(LLVM_EXPORTED_SYMBOL_FILE)
-
 function(dynlib_add_module NAME)
   add_library(${NAME} MODULE
     PipSqueak.cpp

diff  --git a/llvm/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports b/llvm/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports
deleted file mode 100644
index a9122211071ee6..00000000000000
--- a/llvm/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports
+++ /dev/null
@@ -1 +0,0 @@
-TestA


        


More information about the llvm-commits mailing list