[compiler-rt] [scudo] Fix release to OS logic in secondary cache. (PR #103303)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 13 13:54:19 PDT 2024
ChiaHungDuan wrote:
> > This is a fix, please mention that in the title and the description. In addition, I think this can be covered by the test, right? If so, please add a test case.
>
> The main issue with testing this is that the interval at which the issue occurs is somewhat arbitrary. I can try different cache sizes and interval values to determine a point where the error occurs, but I don't think that's a robust way of testing this case. I will try coming up with a better way of testing this outside of the current `CacheOrder` test.
IIRC, we want to ensure the eviction order is still LRU. If we do a page releasing before the first eviction, we will see the wrong order happens, right?
https://github.com/llvm/llvm-project/pull/103303
More information about the llvm-commits
mailing list