[llvm] [SelectionDAG] Move SelectionDAG::getAllOnesConstant out of line. NFC (PR #102995)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 12 20:02:10 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-selectiondag
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
This function has to get the scalar size and create an APInt. I don't think it belongs inline.
---
Full diff: https://github.com/llvm/llvm-project/pull/102995.diff
2 Files Affected:
- (modified) llvm/include/llvm/CodeGen/SelectionDAG.h (+1-4)
- (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (+6)
``````````diff
diff --git a/llvm/include/llvm/CodeGen/SelectionDAG.h b/llvm/include/llvm/CodeGen/SelectionDAG.h
index 1d0124ec755352..9ce3c48a7f76cb 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAG.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAG.h
@@ -675,10 +675,7 @@ class SelectionDAG {
bool isTarget = false, bool isOpaque = false);
SDValue getAllOnesConstant(const SDLoc &DL, EVT VT, bool IsTarget = false,
- bool IsOpaque = false) {
- return getConstant(APInt::getAllOnes(VT.getScalarSizeInBits()), DL, VT,
- IsTarget, IsOpaque);
- }
+ bool IsOpaque = false);
SDValue getConstant(const ConstantInt &Val, const SDLoc &DL, EVT VT,
bool isTarget = false, bool isOpaque = false);
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index c3a7df5361cd45..fcf28f00a1008e 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -1748,6 +1748,12 @@ SDValue SelectionDAG::getConstant(const ConstantInt &Val, const SDLoc &DL,
return Result;
}
+SDValue SelectionDAG::getAllOnesConstant(const SDLoc &DL, EVT VT,
+ bool IsTarget, bool IsOpaque) {
+ return getConstant(APInt::getAllOnes(VT.getScalarSizeInBits()), DL, VT,
+ IsTarget, IsOpaque);
+}
+
SDValue SelectionDAG::getIntPtrConstant(uint64_t Val, const SDLoc &DL,
bool isTarget) {
return getConstant(Val, DL, TLI->getPointerTy(getDataLayout()), isTarget);
``````````
</details>
https://github.com/llvm/llvm-project/pull/102995
More information about the llvm-commits
mailing list