[llvm] [cmake] Allow multiple LibEdit_LIBRARIES (PR #93896)

Romain Geissler via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 18:09:38 PDT 2024


Romain-Geissler-1A wrote:

Hi,

I fail to understand how with the current code `LibEdit_LIBRARIES` can be a list. At the beginning of the file, it seems `LibEdit_LIBRARIES` is always defined to be a single string, not a list, with:

```
find_path(LibEdit_INCLUDE_DIRS NAMES histedit.h HINTS ${PC_LIBEDIT_INCLUDE_DIRS})
find_library(LibEdit_LIBRARIES NAMES edit HINTS ${PC_LIBEDIT_LIBRARY_DIRS})
```

It seems we totally loose the list part, which is stored in `PC_LIBEDIT_LIBRARIES`. Shouldn't we reset `LibEdit_LIBRARIES = "${PC_LIBEDIT_LIBRARIES}"` if all check pass (and similarly for include dirs) ? Or maybe concat PC_LIBEDIT_LIBRARIES & LibEdit_LIBRARIES so that it will work even when nothing is found from pkg-file but found from manually added -I/-L flags ?

https://github.com/llvm/llvm-project/pull/93896


More information about the llvm-commits mailing list