[llvm] [RuntimeDyld][Windows] Allocate space for dllimport things. (PR #102586)

Ben Barham via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 15:26:49 PDT 2024


================
@@ -119,4 +119,14 @@ bool RuntimeDyldCOFF::isCompatibleFile(const object::ObjectFile &Obj) const {
   return Obj.isCOFF();
 }
 
+bool RuntimeDyldCOFF::relocationNeedsDLLImportStub(
+    const RelocationRef &R) const {
+  object::symbol_iterator Symbol = R.getSymbol();
+  Expected<StringRef> TargetNameOrErr = Symbol->getName();
+  if (!TargetNameOrErr)
+    return false;
+
+  return TargetNameOrErr->startswith(getImportSymbolPrefix());
----------------
bnbarham wrote:

```suggestion
  return TargetNameOrErr->starts_with(getImportSymbolPrefix());
```

https://github.com/llvm/llvm-project/pull/102586


More information about the llvm-commits mailing list