[llvm] [Sample Profile] Expand functionality of llvm-profdata function filter (PR #101615)
David Li via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 12 13:47:26 PDT 2024
david-xl wrote:
> > Would you consider using globs (https://llvm.org/doxygen/classllvm_1_1GlobPattern.html) instead of regex? I believe globs are powerful enough for function names and they are much simpler to write/understand than regex. I'll leave it up to you.
>
> I agree, I don't think we should be adding new uses of regular expressions unless absolutely necessary since they tend to be more error prone. In this case globs should be sufficient.
No particular preference, but why should regular expression be avoided and why it is error prone? Do you mean there are different flavors of regexp to make it hard to use?
https://github.com/llvm/llvm-project/pull/101615
More information about the llvm-commits
mailing list