[compiler-rt] [llvm] [ORC][Runtime] Enhancing ELF Platform with Push-Request Model for Initializers (PR #102846)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 11 21:09:12 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 26814bbd4f65934d4e231ce407ec1b62c9d81df7 1e0785cb2b934f0955103dbed8723570506591ed --extensions cpp,h -- compiler-rt/lib/orc/common.h compiler-rt/lib/orc/elfnix_platform.cpp compiler-rt/lib/orc/elfnix_platform.h llvm/include/llvm/ExecutionEngine/Orc/ELFNixPlatform.h llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/compiler-rt/lib/orc/common.h b/compiler-rt/lib/orc/common.h
index 0db540c4dfd..e659f1ae13e 100644
--- a/compiler-rt/lib/orc/common.h
+++ b/compiler-rt/lib/orc/common.h
@@ -17,8 +17,8 @@
#include "error.h"
#include "executor_address.h"
#include "orc_rt/c_api.h"
-#include <type_traits>
#include <algorithm>
+#include <type_traits>
#include <vector>
/// This macro should be used to define tags that will be associated with
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/ELFNixPlatform.h b/llvm/include/llvm/ExecutionEngine/Orc/ELFNixPlatform.h
index ea417ebdc04..996033029a3 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/ELFNixPlatform.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/ELFNixPlatform.h
@@ -179,7 +179,8 @@ private:
// Associate ELFNixPlatform JIT-side runtime support functions with handlers.
Error associateRuntimeSupportFunctions(JITDylib &PlatformJD);
- void pushInitializersLoop(PushInitializersSendResultFn SendResult, JITDylibSP JD);
+ void pushInitializersLoop(PushInitializersSendResultFn SendResult,
+ JITDylibSP JD);
void rt_recordInitializers(PushInitializersSendResultFn SendResult,
ExecutorAddr JDHeader);
@@ -190,8 +191,8 @@ private:
// Records the addresses of runtime symbols used by the platform.
Error bootstrapELFNixRuntime(JITDylib &PlatformJD);
- Error registerPerObjectSections(
- jitlink::LinkGraph &G,const ELFPerObjectSectionsToRegister &POSR);
+ Error registerPerObjectSections(jitlink::LinkGraph &G,
+ const ELFPerObjectSectionsToRegister &POSR);
Expected<uint64_t> createPThreadKey();
@@ -268,4 +269,3 @@ using SPSELFNixJITDylibDepInfoMap =
} // end namespace llvm
#endif // LLVM_EXECUTIONENGINE_ORC_ELFNIXPLATFORM_H
-
diff --git a/llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp b/llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
index e4b05cdc751..d25eb4a74cc 100644
--- a/llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp
@@ -1,4 +1,5 @@
-//===------ ELFNixPlatform.cpp - Utilities for executing ELFNix in Orc -----===//
+//===------ ELFNixPlatform.cpp - Utilities for executing ELFNix in Orc
+//-----===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -812,11 +813,11 @@ Error ELFNixPlatform::ELFNixPlatformPlugin::registerInitSections(
auto &JBS = MP.JDBootstrapStates[&JD];
for (auto &I : ELFNixPlatformSecs)
JBS.Initializers.push_back(I);
- /*G.allocActions().push_back(
- {{},
- cantFail(WrapperFunctionCall::Create<SPSRegisterInitSectionsArgs>(
- MP.orc_rt_elfnix_deregister_init_sections, HeaderAddr,
- ELFNixPlatformSecs))});*/
+ /*G.allocActions().push_back(
+ {{},
+ cantFail(WrapperFunctionCall::Create<SPSRegisterInitSectionsArgs>(
+ MP.orc_rt_elfnix_deregister_init_sections, HeaderAddr,
+ ELFNixPlatformSecs))});*/
} else {
G.allocActions().push_back(
{cantFail(WrapperFunctionCall::Create<SPSRegisterInitSectionsArgs>(
``````````
</details>
https://github.com/llvm/llvm-project/pull/102846
More information about the llvm-commits
mailing list