[compiler-rt] [profile] Change __llvm_profile_counter_bias etc. types to match llvm (PR #102747)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 11 01:29:42 PDT 2024


rorth wrote:

> I'd prefer fixing this in the other direction, that is changing `InstrLowerer::getCounterAddress` to use `intptr_t`. The bias is an offset from an address so there's no need to use `int64_t` on a 32-bit system.

While that is certainly an option, it has several drawbacks at this point:
- IIUC it would require creating a new profile version and adding support for reading that in addition to the current one.
- That's certainly a larger change and I wonder if it would be appropriate for backporting to the 19.x branch.
- I doubt I'm up to implementing that, while my proposed patch is just fixing the current format.

https://github.com/llvm/llvm-project/pull/102747


More information about the llvm-commits mailing list