[llvm] [RISCV][MC] Remove register substitutions in `RISCVAsmPrinter`. NFC (PR #102728)

Brandon Wu via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 10 19:14:15 PDT 2024


4vtomat wrote:

> > > > > This isn't NFC if you have 1174 lines of tests changing...
> > > > 
> > > > 
> > > > But I guess they're just the `InstAlias` which means the underlying instruction is basically the same, is it not NFC under this condition?
> > > 
> > > 
> > > If it's observable to the user in any way, it's not NFC.
> > > We want to print the aliases because it's more user friendly.
> > 
> > 
> > But why is it not printing alias if we don't substitute the register?
> 
> Because the InstAlias uses the VR register class.

Oh, I see.

https://github.com/llvm/llvm-project/pull/102728


More information about the llvm-commits mailing list