[llvm] [Support] Assert that DomTree nodes share parent (PR #101198)

Sat Aug 10 09:27:04 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-gcc-x86_64-linux-debian` running on `gribozavr4` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/70/builds/2411

Here is the relevant piece of the build log for the reference:
```
Step 5 (compile-openmp) failure: build (failure)
...
/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/ompt-general.cpp:698:65: note: declared here
  698 | OMPT_API_ROUTINE int ompt_get_place_proc_ids(int place_num, int ids_size,
      |                                                                 ^
1 warning generated.
1.413 [4/16/31] Building CXX object openmp/runtime/src/CMakeFiles/omp.dir/kmp_alloc.cpp.o
1.539 [4/15/32] Building CXX object openmp/libompd/src/CMakeFiles/ompd.dir/TargetValue.cpp.o
1.595 [4/14/33] Building CXX object openmp/runtime/src/CMakeFiles/omp.dir/kmp_collapse.cpp.o
1.612 [4/13/34] Building CXX object openmp/libompd/src/CMakeFiles/ompd.dir/omp-icv.cpp.o
1.641 [4/12/35] Building CXX object openmp/runtime/src/CMakeFiles/omp.dir/kmp_lock.cpp.o
1.798 [4/11/36] Building CXX object openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o
FAILED: openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o 
/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domp_EXPORTS -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/i18n -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/include -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/thirdparty/ittnotify -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -fcolor-diagnostics -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -fno-semantic-interposition -fdata-sections -O3 -DNDEBUG -fPIC   -D _GNU_SOURCE -D _REENTRANT -U_GLIBCXX_ASSERTIONS -UNDEBUG -std=c++17 -fno-exceptions -fno-rtti -Wno-covered-switch-default -Wno-frame-address -Wno-strict-aliasing -Wno-switch -Wno-uninitialized -Wno-return-type-c-linkage -Wno-cast-qual -Wno-int-to-void-pointer-cast -MD -MT openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o -MF openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o.d -o openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o -c /b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/kmp_affinity.cpp
clang++: /b/1/openmp-gcc-x86_64-linux-debian/llvm.src/llvm/include/llvm/Support/GenericDomTree.h:401: DomTreeNodeBase<NodeT> *llvm::DominatorTreeBase<llvm::BasicBlock, false>::getNode(const NodeT *) const [NodeT = llvm::BasicBlock, IsPostDom = false]: Assertion `(!BB || Parent == NodeTrait::getParent(const_cast<NodeT *>(BB))) && "cannot get DomTreeNode of block with different parent"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang++ --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domp_EXPORTS -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/i18n -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/include -I/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/thirdparty/ittnotify -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -fcolor-diagnostics -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -fno-semantic-interposition -fdata-sections -O3 -DNDEBUG -fPIC -D _GNU_SOURCE -D _REENTRANT -U_GLIBCXX_ASSERTIONS -UNDEBUG -std=c++17 -fno-exceptions -fno-rtti -Wno-covered-switch-default -Wno-frame-address -Wno-strict-aliasing -Wno-switch -Wno-uninitialized -Wno-return-type-c-linkage -Wno-cast-qual -Wno-int-to-void-pointer-cast -MD -MT openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o -MF openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o.d -o openmp/runtime/src/CMakeFiles/omp.dir/kmp_affinity.cpp.o -c /b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/kmp_affinity.cpp
1.	<eof> parser at end of file
2.	Optimizer
3.	Running pass "function<eager-inv>(float2int,lower-constant-intrinsics,chr,loop(loop-rotate<header-duplication;no-prepare-for-lto>,loop-deletion),loop-distribute,inject-tli-mappings,loop-vectorize<no-interleave-forced-only;no-vectorize-forced-only;>,infer-alignment,loop-load-elim,instcombine<max-iterations=1;no-use-loop-info;no-verify-fixpoint>,simplifycfg<bonus-inst-threshold=1;forward-switch-cond;switch-range-to-icmp;switch-to-lookup;no-keep-loops;hoist-common-insts;sink-common-insts;speculate-blocks;simplify-cond-branch;no-speculate-unpredictables>,slp-vectorizer,vector-combine,instcombine<max-iterations=1;no-use-loop-info;no-verify-fixpoint>,loop-unroll<O3>,transform-warning,sroa<preserve-cfg>,infer-alignment,instcombine<max-iterations=1;no-use-loop-info;no-verify-fixpoint>,loop-mssa(licm<allowspeculation>),alignment-from-assumptions,loop-sink,instsimplify,div-rem-pairs,tailcallelim,simplifycfg<bonus-inst-threshold=1;no-forward-switch-cond;switch-range-to-icmp;no-switch-to-lookup;keep-loops;no-hoist-common-insts;no-sink-common-insts;speculate-blocks;simplify-cond-branch;speculate-unpredictables>)" on module "/b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/kmp_affinity.cpp"
4.	Running pass "slp-vectorizer" on function "_ZN14kmp_topology_t12canonicalizeEiiii"
 #0 0x00000000035370e7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x35370e7)
 #1 0x0000000003534bae llvm::sys::RunSignalHandlers() (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x3534bae)
 #2 0x00000000035364cd llvm::sys::CleanupOnSignal(unsigned long) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x35364cd)
 #3 0x00000000034a48f8 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
 #4 0x00007f00df784140 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x13140)
 #5 0x00007f00df298ce1 raise (/lib/x86_64-linux-gnu/libc.so.6+0x38ce1)
 #6 0x00007f00df282537 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22537)
 #7 0x00007f00df28240f (/lib/x86_64-linux-gnu/libc.so.6+0x2240f)
 #8 0x00007f00df291662 (/lib/x86_64-linux-gnu/libc.so.6+0x31662)
 #9 0x0000000002e9148a (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2e9148a)
#10 0x0000000002749d6a llvm::ScalarEvolution::getOperandsToCreate(llvm::Value*, llvm::SmallVectorImpl<llvm::Value*>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2749d6a)
#11 0x00000000027365f7 llvm::ScalarEvolution::createSCEVIter(llvm::Value*) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x27365f7)
#12 0x0000000002682f06 llvm::getPointersDiff(llvm::Type*, llvm::Value*, llvm::Type*, llvm::Value*, llvm::DataLayout const&, llvm::ScalarEvolution&, bool, bool) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2682f06)
#13 0x0000000004bfcbd6 llvm::slpvectorizer::BoUpSLP::canFormVector(llvm::ArrayRef<llvm::StoreInst*>, llvm::SmallVector<unsigned int, 4u>&) const (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4bfcbd6)
#14 0x0000000004bfd1ab llvm::slpvectorizer::BoUpSLP::findExternalStoreUsersReorderIndices(llvm::slpvectorizer::BoUpSLP::TreeEntry*) const (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4bfd1ab)
#15 0x0000000004bf57b1 llvm::slpvectorizer::BoUpSLP::reorderTopToBottom() (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4bf57b1)
#16 0x0000000004c4d5ea llvm::SLPVectorizerPass::vectorizeStoreChain(llvm::ArrayRef<llvm::Value*>, llvm::slpvectorizer::BoUpSLP&, unsigned int, unsigned int, unsigned int&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4c4d5ea)
#17 0x0000000004c4fdc9 llvm::SLPVectorizerPass::vectorizeStores(llvm::ArrayRef<llvm::StoreInst*>, llvm::slpvectorizer::BoUpSLP&, llvm::DenseSet<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, llvm::DenseMapInfo<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, void>>&)::$_165::operator()(std::set<std::pair<unsigned int, int>, llvm::SLPVectorizerPass::vectorizeStores(llvm::ArrayRef<llvm::StoreInst*>, llvm::slpvectorizer::BoUpSLP&, llvm::DenseSet<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, llvm::DenseMapInfo<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, void>>&)::StoreDistCompare, std::allocator<std::pair<unsigned int, int>>> const&) const SLPVectorizer.cpp:0:0
#18 0x0000000004c4ea5b llvm::SLPVectorizerPass::vectorizeStores(llvm::ArrayRef<llvm::StoreInst*>, llvm::slpvectorizer::BoUpSLP&, llvm::DenseSet<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, llvm::DenseMapInfo<std::tuple<llvm::Value*, llvm::Value*, llvm::Value*, llvm::Value*, unsigned int>, void>>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4c4ea5b)
#19 0x0000000004c4a04d llvm::SLPVectorizerPass::vectorizeStoreChains(llvm::slpvectorizer::BoUpSLP&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4c4a04d)
#20 0x0000000004c487fb llvm::SLPVectorizerPass::runImpl(llvm::Function&, llvm::ScalarEvolution*, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo*, llvm::AAResults*, llvm::LoopInfo*, llvm::DominatorTree*, llvm::AssumptionCache*, llvm::DemandedBits*, llvm::OptimizationRemarkEmitter*) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4c487fb)
#21 0x0000000004c47c5b llvm::SLPVectorizerPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x4c47c5b)
#22 0x0000000004887a5d llvm::detail::PassModel<llvm::Function, llvm::SLPVectorizerPass, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) crtstuff.c:0:0
#23 0x0000000002f5e2e7 llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2f5e2e7)
#24 0x0000000000fc283d llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) crtstuff.c:0:0
#25 0x0000000002f626f0 llvm::ModuleToFunctionPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2f626f0)
#26 0x0000000000fc260d llvm::detail::PassModel<llvm::Module, llvm::ModuleToFunctionPassAdaptor, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) crtstuff.c:0:0
#27 0x0000000002f5d197 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/1/openmp-gcc-x86_64-linux-debian/llvm.build/./bin/clang+++0x2f5d197)
#28 0x0000000003754f1a (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&, clang::BackendConsumer*) BackendUtil.cpp:0:0

```

https://github.com/llvm/llvm-project/pull/101198