[llvm] [SandboxIR][NFC] SingleLLVMInstructionImpl class (PR #102687)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 15:21:54 PDT 2024


================
@@ -713,27 +713,43 @@ class Instruction : public sandboxir::User {
 #endif
 };
 
-class SelectInst : public Instruction {
-  /// Use Context::createSelectInst(). Don't call the
-  /// constructor directly.
-  SelectInst(llvm::SelectInst *CI, Context &Ctx)
-      : Instruction(ClassID::Select, Opcode::Select, CI, Ctx) {}
-  friend Context; // for SelectInst()
+/// Instructions that contain a single LLVM Instruction can inherit from this.
+class SingleLLVMInstructionImpl : public Instruction {
----------------
vporpo wrote:

Good points, let me try to add both verify() and dump().

https://github.com/llvm/llvm-project/pull/102687


More information about the llvm-commits mailing list