[llvm] [llvm-lit][test][NFC] Moved cat command tests into separate lit test file (PR #102366)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 11:12:30 PDT 2024


connieyzhu wrote:

> What do you think about removing `shtest` from the test directory names? I'm not convinced about its value to the test description.

@jh7370 From what I can tell, the test directories with `shtest` are involved with some sort of shell command in their tests, while those without it don't use shell commands (can't say this is 100% true, but just from scanning several files). I do think that having the description is pretty helpful in knowing which tests will involve lit's built-in commands, which I will need to reference as I write tests for other features I'm planning on implementing. So I don't think it's worth removing from every single test directory and test file (there's >15 of them).

https://github.com/llvm/llvm-project/pull/102366


More information about the llvm-commits mailing list