[llvm] [GlobalIsel] Combine G_ADD and G_SUB with constants (PR #97771)

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 11:09:28 PDT 2024


Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/97771 at github.com>


aemerson wrote:

I put an assert into the combine to see when it fires. Essentially across the whole test suite I only see it hit in the MultiSource build variant of sqlite3 once, which saves 4 bytes across ~3.5k binaries. I will approve this but I really think it's not a good use of time to pursue this. If anything this might indicate we should *remove* these combines from SDAG for compile time reasons.

https://github.com/llvm/llvm-project/pull/97771


More information about the llvm-commits mailing list