[llvm] [llvm-mca] Add bottle-neck analysis to JSON output. (PR #90056)

[Phil Camp via llvm-commits]

FlameTop wrote:

Hmm, no I didn’t see them. I will check if they are real etc.

Thanks

Phil

From: Andrea Di Biagio ***@***.***>
Sent: Friday, August 9, 2024 4:13 PM
To: llvm/llvm-project ***@***.***>
Cc: Camp, Phil ***@***.***>; Author ***@***.***>
Subject: Re: [llvm/llvm-project] [llvm-mca] Add bottle-neck analysis to JSON output. (PR #90056)


Have you looked at whether test failures reported by
buildkite/github-pull-requests (https://buildkite.com/llvm-project/github-pull-requests/builds/65010<https://urldefense.com/v3/__https:/buildkite.com/llvm-project/github-pull-requests/builds/65010__;!!JmoZiZGBv3RvKRSx!-Xxs141p5tHFfQlMHmSkSMfxUsDkNtY9LXTJCm6DG-9b2NzweD8j5eXav9zy-1_22SA77bGGfljXxUkSKK_AOVg$> )are genuine ?

The following tests fail after your change:

   LLVM :: tools/llvm-mca/JSON/X86/views-custom-parameters.s

   LLVM :: tools/llvm-mca/JSON/X86/views-multiple-anonymous-regions.s

   LLVM :: tools/llvm-mca/JSON/X86/views-multiple-region.s

   LLVM :: tools/llvm-mca/JSON/X86/views.s

I wonder if some of the CHECK-NEXT should be re-generated after your change.

—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/pull/90056*issuecomment-2278179729__;Iw!!JmoZiZGBv3RvKRSx!-Xxs141p5tHFfQlMHmSkSMfxUsDkNtY9LXTJCm6DG-9b2NzweD8j5eXav9zy-1_22SA77bGGfljXxUkSqBumKRc$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAPJXZYCRX5Q5X6ZQZ7WL43ZQTMBNAVCNFSM6AAAAABGY6SAPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGE3TSNZSHE__;!!JmoZiZGBv3RvKRSx!-Xxs141p5tHFfQlMHmSkSMfxUsDkNtY9LXTJCm6DG-9b2NzweD8j5eXav9zy-1_22SA77bGGfljXxUkSgfCB0NE$>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>



**********************************************************************
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify ***@***.******@***.***>
This footnote also confirms that this email message has been checked for all known viruses.
Sony Interactive Entertainment Europe Limited
Registered Office: 10 Great Marlborough Street, London W1F 7LP, United Kingdom
Registered in England: 3277793
**********************************************************************

P Please consider the environment before printing this e-mail


https://github.com/llvm/llvm-project/pull/90056