[llvm] Revert "LSV: document hang reported in #37865 (#102479)" (PR #102603)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 05:01:39 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-transforms

Author: Ramkumar Ramachandra (artagnon)

<details>
<summary>Changes</summary>

This reverts commit 199d6f2, as there is a buildbot failure.

---
Full diff: https://github.com/llvm/llvm-project/pull/102603.diff


2 Files Affected:

- (modified) llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp (-2) 
- (removed) llvm/test/Transforms/LoadStoreVectorizer/AArch64/pr37865.ll (-15) 


``````````diff
diff --git a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
index c35ea431296b70..c91911ecad7456 100644
--- a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
@@ -216,8 +216,6 @@ void reorder(Instruction *I) {
       if (IM->getParent() != I->getParent())
         continue;
 
-      assert(IM != I && "Unexpected cycle while re-ordering instructions");
-
       if (!IM->comesBefore(I)) {
         InstructionsToMove.insert(IM);
         Worklist.push_back(IM);
diff --git a/llvm/test/Transforms/LoadStoreVectorizer/AArch64/pr37865.ll b/llvm/test/Transforms/LoadStoreVectorizer/AArch64/pr37865.ll
deleted file mode 100644
index 833e70814c2917..00000000000000
--- a/llvm/test/Transforms/LoadStoreVectorizer/AArch64/pr37865.ll
+++ /dev/null
@@ -1,15 +0,0 @@
-; REQUIRES: asserts
-; RUN: not --crash opt -mtriple=aarch64 -passes=load-store-vectorizer \
-; RUN:   -disable-output %s 2>&1 | FileCheck %s
-
-define i32 @load_cycle(ptr %x) {
-; CHECK: Unexpected cycle while re-ordering instructions
-entry:
-  %gep.x.1 = getelementptr inbounds [2 x i32], ptr %x, i32 0, i32 1
-  %load.x.1 = load i32, ptr %gep.x.1
-  %rem = urem i32 %load.x.1, 1
-  %gep.x.2 = getelementptr inbounds [2 x i32], ptr %x, i32 %rem, i32 0
-  %load.x.2 = load i32, ptr %gep.x.2
-  %ret = add i32 %load.x.2, %load.x.1
-  ret i32 %ret
-}

``````````

</details>


https://github.com/llvm/llvm-project/pull/102603


More information about the llvm-commits mailing list