[llvm] e129530 - [CodeGen][NewPM] Improve start/stop pass error message CodeGenPassBuilder (#102591)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 04:16:26 PDT 2024


Author: Akshat Oke
Date: 2024-08-09T16:46:22+05:30
New Revision: e12953028584b3dad5f538c827cefe8fc421bd52

URL: https://github.com/llvm/llvm-project/commit/e12953028584b3dad5f538c827cefe8fc421bd52
DIFF: https://github.com/llvm/llvm-project/commit/e12953028584b3dad5f538c827cefe8fc421bd52.diff

LOG: [CodeGen][NewPM] Improve start/stop pass error message CodeGenPassBuilder (#102591)

Remove the pass-name-to-class-name lookup because it does not exist
(that's why this error is thrown). Print the name given as the option
instead.

Co-authored-by: Akshat Oke <Akshat.Oke at amd.com>

Added: 
    

Modified: 
    llvm/include/llvm/Passes/CodeGenPassBuilder.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Passes/CodeGenPassBuilder.h b/llvm/include/llvm/Passes/CodeGenPassBuilder.h
index 81c00a3a95c113..3cc39b54ba758d 100644
--- a/llvm/include/llvm/Passes/CodeGenPassBuilder.h
+++ b/llvm/include/llvm/Passes/CodeGenPassBuilder.h
@@ -610,13 +610,11 @@ Error CodeGenPassBuilder<Derived, TargetMachineT>::verifyStartStop(
 
   if (!Started)
     return make_error<StringError>(
-        "Can't find start pass \"" +
-            PIC->getPassNameForClassName(Info.StartPass) + "\".",
+        "Can't find start pass \"" + Info.StartPass + "\".",
         std::make_error_code(std::errc::invalid_argument));
   if (!Stopped)
     return make_error<StringError>(
-        "Can't find stop pass \"" +
-            PIC->getPassNameForClassName(Info.StopPass) + "\".",
+        "Can't find stop pass \"" + Info.StopPass + "\".",
         std::make_error_code(std::errc::invalid_argument));
   return Error::success();
 }


        


More information about the llvm-commits mailing list