[llvm] [CodeGen][NewPM] Improve start/stop pass error message CodeGenPassBuilder (PR #102591)

Akshat Oke via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 03:19:43 PDT 2024


https://github.com/Akshat-Oke updated https://github.com/llvm/llvm-project/pull/102591

>From edf07abd74195a9060639f45e635623628a5dfc7 Mon Sep 17 00:00:00 2001
From: Akshat Oke <Akshat.Oke at amd.com>
Date: Fri, 9 Aug 2024 09:39:19 +0000
Subject: [PATCH] [CodeGen][NewPM] Improve start/stop error message

Remove the pass-name-to-class-name lookup because it does not exist (that's why this error is thrown). Print the given name in the option instead.
---
 llvm/include/llvm/Passes/CodeGenPassBuilder.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/llvm/include/llvm/Passes/CodeGenPassBuilder.h b/llvm/include/llvm/Passes/CodeGenPassBuilder.h
index 81c00a3a95c113..3cc39b54ba758d 100644
--- a/llvm/include/llvm/Passes/CodeGenPassBuilder.h
+++ b/llvm/include/llvm/Passes/CodeGenPassBuilder.h
@@ -610,13 +610,11 @@ Error CodeGenPassBuilder<Derived, TargetMachineT>::verifyStartStop(
 
   if (!Started)
     return make_error<StringError>(
-        "Can't find start pass \"" +
-            PIC->getPassNameForClassName(Info.StartPass) + "\".",
+        "Can't find start pass \"" + Info.StartPass + "\".",
         std::make_error_code(std::errc::invalid_argument));
   if (!Stopped)
     return make_error<StringError>(
-        "Can't find stop pass \"" +
-            PIC->getPassNameForClassName(Info.StopPass) + "\".",
+        "Can't find stop pass \"" + Info.StopPass + "\".",
         std::make_error_code(std::errc::invalid_argument));
   return Error::success();
 }



More information about the llvm-commits mailing list