[llvm] [llvm-lit] Fix Unhashable TypeError when using lit's internal shell (PR #101590)
Paul Kirth via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 16:35:16 PDT 2024
https://github.com/ilovepi approved this pull request.
Given the fact that only selectively expanding `arg[0]` seems to be causing more expansions and fix ups, I'm OK with the current approach.
However, the description is still unclear, despite the template I provided.
Please include:
1. an example of the command that triggers this error
2. at least one example of where this happens in our codebase
1. conditions for running the test w/ the internal shell
2. remove "This patch eliminates the 'unhashable type: GlobItem' error." (at most this stops 1 specific instance from occurring).
These details will help others coming by later understand why you're making this change. It's also worth including a link to the RFC to let others know this is part of that effort/cleanup.
https://github.com/llvm/llvm-project/pull/101590
More information about the llvm-commits
mailing list