[llvm] [llvm-lit] Adding -e option to lit's built-in cat command (PR #102061)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 01:34:31 PDT 2024
jh7370 wrote:
> > One question I do have is how many tests actually use this functionality and do they really need to?
>
> @jh7370 I believe only one test currently uses cat -e. I'm not quite sure what its purpose is, but it's in [TestUseColor.test](https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/Driver/TestUseColor.test#L4) in `lldb`.
Thanks, I don't see the need for the `$` line ending behaviour in that test. It's possible the non-printing characters behaviour is needed though. @JDevlieghere, since you last touched that test, can you confirm the purpose of the -e usage is to print non-printing characters?
We should avoid adding functionality that isn't needed, so for example, -v might be more appropriate in that test, which would then allow us to avoid adding -e functionality.
https://github.com/llvm/llvm-project/pull/102061
More information about the llvm-commits
mailing list