[llvm] [TableGen] Rework error reporting for duplicate Feature/Processor. (PR #102257)
Sergei Barannikov via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 16:43:23 PDT 2024
s-barannikov wrote:
> I realized that I forgot to update the commit message to describe the getID() changes :( It has:
>
> ```
> - Make the sorting deterministic by using record name as a secondary
> key for sorting, and re-enable SubtargetFeatureUniqueNames.td test
> that was disabled due to the non-determinism of the error messages.
> - Change wording of error message when duplicate records are found to
> be source code position agnostic, since `First` may not be before
> `Second` lexically.
> ```
>
> Oh well, need to be more careful next time.
Yeah, my bad too. I was to tired to read it to the end.
https://github.com/llvm/llvm-project/pull/102257
More information about the llvm-commits
mailing list