[llvm] [llvm-readobj][COFF] Dump hybrid object for ARM64X files. (PR #102245)

Jacek Caban via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 15:27:11 PDT 2024


================
@@ -360,8 +360,8 @@ createDumper(const ObjectFile &Obj, ScopedPrinter &Writer) {
 }
 
 /// Dumps the specified object file.
-static void dumpObject(ObjectFile &Obj, ScopedPrinter &Writer,
-                       const Archive *A = nullptr) {
+void ObjDumper::dumpObject(ObjectFile &Obj, ScopedPrinter &Writer,
----------------
cjacek wrote:

Thanks for the feedback. I tried moving `dumpObject` to `ObjDumper.cpp`, but that would require making a number of `opts` variables non-static and became a bit messy. Instead, I kept is static and changed it to be more similar to `dumpMachOUniversalBinary`: I used a separate branch in `dumpInput` for COFF files, where I call `dumpObject` twice in case for hybrid objects. That made the change quite simple.

Also, following the suggestion from #102071, I changed tests to use `--match-full-lines` and `--strict-whitespace` to make sure that indention works as expected.

https://github.com/llvm/llvm-project/pull/102245


More information about the llvm-commits mailing list