[compiler-rt] [NFC] Fix typo in `REAL(pthread_join(th, ret))` (PR #102393)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 15:03:06 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Vitaly Buka (vitalybuka)
<details>
<summary>Changes</summary>
Looks like the macro expands to the same,
but usually we do `REAL(pthread_join)(th, ret)`.
---
Full diff: https://github.com/llvm/llvm-project/pull/102393.diff
2 Files Affected:
- (modified) compiler-rt/lib/sanitizer_common/sanitizer_posix.h (+1-1)
- (modified) compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp (+1-1)
``````````diff
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_posix.h b/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
index 14617e4771bec4..d0954f77e97136 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_posix.h
@@ -86,7 +86,7 @@ int internal_pthread_join(void *th, void **ret);
return REAL(pthread_create)(th, attr, callback, param); \
} \
int internal_pthread_join(void *th, void **ret) { \
- return REAL(pthread_join(th, ret)); \
+ return REAL(pthread_join)(th, ret); \
} \
} // namespace __sanitizer
diff --git a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
index 9cab2a37271288..1be65bc99b260d 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
@@ -1097,7 +1097,7 @@ int internal_pthread_create(void *th, void *attr, void *(*callback)(void *),
}
int internal_pthread_join(void *th, void **ret) {
ScopedIgnoreInterceptors ignore;
- return REAL(pthread_join(th, ret));
+ return REAL(pthread_join)(th, ret);
}
} // namespace __sanitizer
``````````
</details>
https://github.com/llvm/llvm-project/pull/102393
More information about the llvm-commits
mailing list