[llvm] Revert "[BOLT] Move ADRRelaxationPass (#101371)" (PR #102333)
Vladislav Khmelevsky via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 10:01:54 PDT 2024
https://github.com/yota9 created https://github.com/llvm/llvm-project/pull/102333
This reverts commit 750b12f06badc4cdf767139c70090db62358bb44.
The pass should run after splitting phase, but before nop removal
>From 8d4bf7d2f53f842619acb07ccc1ec69d0417b8ca Mon Sep 17 00:00:00 2001
From: Vladislav Khmelevsky <och95 at yandex.ru>
Date: Wed, 7 Aug 2024 21:00:01 +0400
Subject: [PATCH] Revert "[BOLT] Move ADRRelaxationPass (#101371)"
This reverts commit 750b12f06badc4cdf767139c70090db62358bb44.
The pass should run after splitting phase, but before nop removal
---
bolt/lib/Rewrite/BinaryPassManager.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bolt/lib/Rewrite/BinaryPassManager.cpp b/bolt/lib/Rewrite/BinaryPassManager.cpp
index dadb1f4d833b0..5dfef0b71cc79 100644
--- a/bolt/lib/Rewrite/BinaryPassManager.cpp
+++ b/bolt/lib/Rewrite/BinaryPassManager.cpp
@@ -357,8 +357,6 @@ Error BinaryFunctionPassManager::runAllPasses(BinaryContext &BC) {
Manager.registerPass(
std::make_unique<VeneerElimination>(PrintVeneerElimination));
-
- Manager.registerPass(std::make_unique<ADRRelaxationPass>());
}
if (BC.isRISCV()) {
@@ -492,6 +490,8 @@ Error BinaryFunctionPassManager::runAllPasses(BinaryContext &BC) {
Manager.registerPass(std::make_unique<ReorderData>());
if (BC.isAArch64()) {
+ Manager.registerPass(std::make_unique<ADRRelaxationPass>());
+
// Tighten branches according to offset differences between branch and
// targets. No extra instructions after this pass, otherwise we may have
// relocations out of range and crash during linking.
More information about the llvm-commits
mailing list