[llvm] [llvm-lit][test] Precommit tests for lit's built-in cat command (PR #101530)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 23:41:13 PDT 2024


jh7370 wrote:

> I realized I somehow grepped incorrectly, and there actually already exists tests for `cat`. In my most recent patch, I've removed the test files I made and added a new test for `-e` in the existing file. Sorry for the inconvenience, I appreciate your patience.

No problem.

> > As above, consider adding `--implicit-check-not={{.}}`, `--strict-whitespace`, and `--match-full-lines` to the FileCheck commands.
> 
> @jh7370 I've added these options to the new `-e` test I added to `valid-shell.txt`. The other existing tests in this file don't seem to have these options set for FileCheck, and also have grammar/punctuation issues that you mentioned before. Do you think I should make these changes to the existing tests too?

I think the typical LLVM process would be to improve the existing tests first in a PR prior to this one, then base this PR on top of it. You could use a tool like spr to stack your PRs, to aid with this, or just keep them separate then rebase this PR once you land the first one.

https://github.com/llvm/llvm-project/pull/101530


More information about the llvm-commits mailing list