[llvm] [DomTreeUpdater] Handle critical edge splitting (PR #100856)

via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 18:20:32 PDT 2024


================
@@ -146,8 +152,25 @@ class GenericDomTreeUpdater {
   /// 2. It is illegal to submit any update that has already been submitted,
   /// i.e., you are supposed not to insert an existent edge or delete a
   /// nonexistent edge.
+  /// 3. This kind updates are incompatible with critical edge splitting
+  /// updates, call this method will apply all critical edge updates in
+  /// lazy mode. It is not recommended to interleave applyUpdates and
+  /// applyUpdatesForCriticalEdgeSplitting.
----------------
paperchalice wrote:

Currently all update operations are based on [`cfg::Update`](https://llvm.org/doxygen/classllvm_1_1cfg_1_1Update.html). If we extend `cfg::Update` directly e.g. add a new kind `UpdateKind::Split`, then it is duplicated with two insertions and deletion, and causes some compiler warnings.


https://github.com/llvm/llvm-project/pull/100856


More information about the llvm-commits mailing list