[llvm] [AMDGPU] Correctly insert s_nops for dst forwarding hazard (PR #100276)

Jeffrey Byrnes via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 13:22:19 PDT 2024


================
@@ -2904,6 +2905,15 @@ def getVCMPXOpFromVCMP : InstrMapping {
   let ValueCols = [["1"]];
 }
 
+def FP8DstByteSelTable : GenericTable {
+  let FilterClass = "VOP3_Pseudo";
----------------
jrbyrnes wrote:

> I think, its better to filter it on encoded variants of the instruction

I'm not sure there is any reason to consider the encoded variants / I think VOP3_Pseudo filter is fine. Based on my understanding, the VOP3_Pseudos will be used during CodeGen / HazardRecognizer, and the encoded variants / opcodes aren't introduced until MCLayer.

https://github.com/llvm/llvm-project/pull/100276


More information about the llvm-commits mailing list